Conversation
Pull Request Test Coverage Report for Build 19322395186Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the build system from setuptools to scikit-build-core with CMake for building the C++ extension module. The migration removes the traditional setup.py approach and moves all configuration to pyproject.toml and a new CMakeLists.txt file.
Key changes:
- Replaces setuptools build backend with scikit-build-core in
pyproject.toml - Removes
setup.pyentirely, moving extension build configuration to CMake - Adds
CMakeLists.txtwith platform-specific compiler flags and C++ extension configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Removed entire setuptools-based build configuration |
| pyproject.toml | Updated build system to use scikit-build-core and added CMake configuration settings |
| CMakeLists.txt | New file defining C++ extension build with CMake, including include paths and platform flags |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I have started to update Drudge to C++20. In fact, I wanted to update |
|
I will also try to take a look at it next week and can help you out with the upgrades. Also, unrelated, but we used to have a pypi package for drudge. We should try to reconfigure one for drudge and gristmill. I have some experience with it and can try to look into it. |
|
That would be great. Thanks! For PyPI registration, I wonder whether it can be automated. Ideally, after each release, the bot can automatically register the package. Currently, I'm using release-please for automated releases. However, it does not work very well with the Python ecosystem. For example, it cannot automatically update the |
|
AFAIK, pypi packages can be automatically deployed, but it may end up creating a lot of versions. Instead, a better practice is to wait until sufficient changes are introduced and then release a new version/subversion. |
|
Sounds good to me. We should probably do manual deployment for now. In the long run, we can consider continuous deployment for major releases only. |
chenpeizhi
left a comment
chenpeizhi
left a comment
There was a problem hiding this comment.
Everything looks good to me. Thanks!
**Keeping C++ standard set at C++20/ But we should try to keep drudge and gristmill deps consistent.